[장보배] Sprint 5 #296
Merged
[장보배] Sprint 5 #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withyj-codeit
approved these changes
Jan 22, 2025
| */} | ||
| </div> | ||
| ) | ||
| } No newline at end of file |
There was a problem hiding this comment.
vscode에서 end of line 설정해주시면 좋을 것 같아요. (참고)
| }; | ||
|
|
||
| fetchData(); | ||
| }, []); |
There was a problem hiding this comment.
데이터 받는 부분 커스텀 훅 만들고, AllItems, BestItems에서 사용하는 방향으로 리팩토링 해보면 좋을 것 같아요.
There was a problem hiding this comment.
React 컴포넌트 파일이름의 경우 대문자로 시작하는 경우가 일반적이라 이후에 만드실 때는 대문자로 시작하도록 만들어보시면 좋을 것 같아요.
| <p className={style.favouriteCount}>❤️{item.favourtieCount}</p> | ||
| </div> | ||
|
|
||
|
|
There was a problem hiding this comment.
불필요한 여백들은 제거하면서 깔끔하게 유지하시면 좋아요.
| to="/communityboard">자유게시판</Link> | ||
| <Link | ||
| className={style.navbuttonspages} | ||
| to="/thriftmarket">중고마켓</Link> |
There was a problem hiding this comment.
필요한 경우 NavLink 사용도 고려해보면 좋아요. (참고)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게