Skip to content

Conversation

predator4hack
Copy link
Contributor

…signup card

Signed-off-by: predator4hack chandankum2440@gmail.com

Pull Request Template

Description

The bottom of the fotter signup and login pages had whitespaces, which has now been rectified. Additionally, the Signin/Login cards were not centred for some screen sizes, which has now been fixed.

Fixes #68

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

…signup card

Signed-off-by: predator4hack <chandankum2440@gmail.com>
@padmajabhol padmajabhol self-requested a review April 5, 2022 05:00
Copy link
Member

@padmajabhol padmajabhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some whitespace on the login page. Also, disable the horizontal scrollbar.

@padmajabhol
Copy link
Member

@predator4hack any updates?

@ikayz
Copy link
Contributor

ikayz commented Apr 25, 2022

@predator4hack have the merge conflicts been resolved?

@ikayz ikayz closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signup page bottom whitespace and signup card is not in the center for some screen sizes

3 participants