navbar fixed for home page

[roshanchatei]

@ikayz now review it, I have done as you said.

[roshanchatei]

@ikayz
And please delete the other branch i.e. "navbar-fix"

[roshanchatei]

@ikayz ??

[roshanchatei]

@ikayz I just want to know if I have done it correctly or not so I can go forward. So if you are then please guide me.

[roshanchatei]

@ikayz I just want to know if I have done it correctly or not so I can go forward. So if you are then please guide me.
*if you are free

[ikayz]

@roshanchatei I will look at it

[roshanchatei]

@roshanchatei I will look at it
@ikayz thanks a lot
let me know as soon as possible.

[roshanchatei]

@ikayz have you checked it??

[ikayz]

@roshanchatei I had a look at the PR and it doesn't compile. Please see the attached screenshot

[roshanchatei]

@ikayz its working fine for me, I have attached the ss

[roshanchatei]

@ikayz ??

[ikayz]

@roshanchatei the first screenshot was on a Mac. I've attached a different screenshot on a Windows machine and getting the same error.

[ikayz]

@roshanchatei the branch you made a PR from is roshan/navbar-fix correct?

[ikayz]

@JPTIZ this PR has an error that's preventing the project from rendering. He needs to fix it first @roshanchatei. I've tried it on both Mac and Windows, the error is the same.

[ikayz]

@roshanchatei

[roshanchatei]

@roshanchatei the branch you made a PR from is roshan/navbar-fix correct?
@ikayz you are right.
I think I made a mistake while resolving conflict.
let me make a new PR.

[roshanchatei]

@ikayz I made a mistake while resolving the conflict

Just add '}' at line 7 of Header.css and It will work.
I am really sorry.

[roshanchatei]

@ikayz can u please add '}' in Header.css and check if it's working or not.
And let me know if its working or not so that I can make some more changes.

[roshanchatei]

I am not able to push again to the same branch so I asked you to add '}'

So what should I do: Make a new PR??

[roshanchatei]

@ikayz

[roshanchatei]

@JPTIZ @ikayz ?

[yochannah]

@roshanchatei Please do remember that this is a volunteer project, so responses may take a few days sometimes 😁

[JPTIZ]

I am not able to push again to the same branch so I asked you to add '}'

So what should I do: Make a new PR??

Hm, did you overwrite any previous commit (for example, with git commit --amend or something like, or even a git rebase [...]) on you local history? If it is the case and you are 100% sure your local history is fine (for example, that you didn't delete a commit by accident and the changes are just as you expected them to be), try using --force-with-lease on git push.

[ikayz]

@roshanchatei try what @JPTIZ has suggested

[roshanchatei]

@roshanchatei Please do remember that this is a volunteer project, so responses may take a few days sometimes 😁

ok, I will keep that in mind.

[roshanchatei]

I am not able to push again to the same branch so I asked you to add '}'
So what should I do: Make a new PR??

Hm, did you overwrite any previous commit (for example, with git commit --amend or something like, or even a git rebase [...]) on you local history? If it is the case and you are 100% sure your local history is fine (for example, that you didn't delete a commit by accident and the changes are just as you expected them to be), try using --force-with-lease on git push.

thanks for helping me out.
let me check and get back.

[roshanchatei]

@ikayz @JPTIZ
Now check it!

[roshanchatei]

@ikayz @JPTIZ ??

[JPTIZ]

@ikayz @JPTIZ ??

Hey, don't worry, I have a queue of issues I have to check so you don't need to ping from time to time. Some of us get very busy so reviewing is not always so quick, I gently ask you to be patient :)

Unless, of course, you're in a hurry (needing to finish a contribution so you get evaluated in an interview or something like that).

[ikayz]

@roshanchatei thanks for the PR, there seems to be another issue. Please refer to the screenshot. I ran the project using the roshan/navbar-fix branch

[roshanchatei]

@roshanchatei thanks for the PR, there seems to be another issue. Please refer to the screenshot. I ran the project using the roshan/navbar-fix branch

I have used Material UI, so you need to install its dependencies before running.
npm install @mui/material @emotion/react @emotion/styled

[roshanchatei]

@ikayz @JPTIZ ??

Hey, don't worry, I have a queue of issues I have to check so you don't need to ping from time to time. Some of us get very busy so reviewing is not always so quick, I gently ask you to be patient :)

Unless, of course, you're in a hurry (needing to finish a contribution so you get evaluated in an interview or something like that).

I am really sorry about it, I won't do it again.
Actually, I am not in a hurry, I fixed the issue from the 'master' branch, but Issac asked me to work on the latest commit i.e. from the 'development' branch, so I did. I just want to know if I have done this correctly and if I am working on the latest commit of the development branch so I can start working on other pages navbar issue, that's all.

I am here to learn not for any interview evaluation, my friends recommended me to contribute to open source because it has one the best community and here I can learn new skills and improve my skills too as I learned from my GIT PUSH issue.

It would be very helpful if someone could tell me if I am working on the latest commit of the development branch, so I can start working on other pages navbar issues.

[ikayz]

@roshanchatei thanks for your efforts and work, however, I've noticed you are using new dependencies the project isn't using Material UI and Emotion. As of now, we are using React Bootstrap, I recommend you use that for your components. Having multiple UI libraries in the same project isn't a great idea at this stage and the Read me does mention React Bootstrap. Please do consult or refer to the contributing guide before adding dependencies the origin repo isn't using.

[roshanchatei]

@roshanchatei thanks for your efforts and work, however, I've noticed you are using new dependencies the project isn't using Material UI and Emotion. As of now, we are using React Bootstrap, I recommend you use that for your components. Having multiple UI libraries in the same project isn't a great idea at this stage and the Read me does mention React Bootstrap. Please do consult or refer to the contributing guide before adding dependencies the origin repo isn't using.

ok let me use react-bootstrap and then get back

[ikayz]

Awesome thanks 🙏🏾

[ikayz]

@roshanchatei just checking on this issue. If you were able to make the requested changes or should it be assigned to someone else?

[roshanchatei]

Yes I am working on it

[roshanchatei]

@roshanchatei just checking on this issue. If you were able to make the requested changes or should it be assigned to someone else?

my semester exams were going on, now I will be contributing to this project

[roshanchatei]

@yochannah @ikayz I had send an email for the Project Proposal can u you please check it out?

[roshanchatei]

@ikayz @yochannah ?

[yochannah]

@roshanchatei thanks for still working on this - let's try and keep discussions in issues on-topic where we can though, thanks! :) (and you're in the slack now too which will help :) )