Skip to content

Conversation

roshanchatei
Copy link
Contributor

@roshanchatei roshanchatei commented Apr 19, 2022

Description

Added bottom margin to the input fields so that when focused on the input field, the bottom border is not being hidden behind the other input field

Fixes #94

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

@padmajabhol padmajabhol self-requested a review April 20, 2022 08:21
@padmajabhol padmajabhol changed the title add Journal form fixed fix journal form Apr 20, 2022
Copy link
Member

@padmajabhol padmajabhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roshanchatei , why do we need the ./idea folder? If not, please delete it. Apart from that, everything looks fine.

@roshanchatei
Copy link
Contributor Author

@padmajabhol its because I use IntelliJ IDEA as my text editor, to remove it the maintainer needs to add '/.next/' to .gitignore

@padmajabhol
Copy link
Member

@padmajabhol its because I use IntelliJ IDEA as my text editor, to remove it the maintainer needs to add '/.next/' to .gitignore

You can do this when you send a commit or add additional commits in this particular PR to do the same.

@roshanchatei
Copy link
Contributor Author

@padmajabhol its because I use IntelliJ IDEA as my text editor, to remove it the maintainer needs to add '/.next/' to .gitignore

You can do this when you send a commit or add additional commits in this particular PR to do the same.

Ok

@roshanchatei
Copy link
Contributor Author

@padmajabhol now can you check it out

@ikayz
Copy link
Contributor

ikayz commented Apr 25, 2022

@padmajabhol are you good with this now?

@padmajabhol
Copy link
Member

@padmajabhol are you good with this now?

Couldn't check, was away for a few days, doing right away.

Copy link
Member

@padmajabhol padmajabhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but I'm not able to click on anything on your branch, can you look into this? Let me know if you need help. Sorry for the late review since I was away for a few days.

@roshanchatei
Copy link
Contributor Author

I'm not sure but I'm not able to click on anything on your branch, can you look into this? Let me know if you need help. Sorry for the late review since I was away for a few days.

Ok, I will look into it

@ikayz ikayz closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Policies Input fields border are overlapping

3 participants