Use default templates for allcontributors #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in #87 (comment), defining a stub `contributorTemplate` have side effects such as taking off the emojis (since they're not part of the template). Since we're not using anything specific in the template (instead, we're just using a standard minimalist example template), we can rely on the default allcontributors' template parameters to generate the default HTML with emojis back.
Collaborator
|
This appears to possibly be in a perpetual merge conflict loop - merging now. We might need to check that this doesn't happen next time and possibly tweak things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #87 (comment), defining a stub
contributorTemplatehave side effects such as taking off the emojis (since they're not part of the template). Since we're not using anything specific in the template (instead, we're just using a standard minimalist example template), we can rely on the default allcontributors' template parameters to generate the default HTML with emojis back.This is not enough to fix #87, but it is the first step. We probably will have to re-add contributors after this is merged in order for emojis to appear.