Skip to content

Conversation

@alokpant
Copy link
Collaborator

@alokpant alokpant commented Jun 5, 2018

Links to relevant issues/docs#
Fixes: #48 and #49

What does this PR do?

Summary of changes you made:

  • Create variables for Colors instead of Hex codes
  • Center align footer text
  • Add hover color to footer text

Additional information

screen shot 2018-06-05 at 19 51 44

Hover color:
screen shot 2018-06-05 at 19 47 52

@alokpant
Copy link
Collaborator Author

alokpant commented Jun 6, 2018

@yochannah Can you please provide feedback? I centred it and add hover color on links too.

@yochannah
Copy link
Collaborator

thanks for the reminder! It looks great. I'll quickly check it out and make sure it runs ok on my machine.

@yochannah yochannah merged commit 54dd528 into codeisscience:master Jun 6, 2018
@yochannah
Copy link
Collaborator

@alokpant Perfect! Thanks so much!

@alokpant alokpant deleted the links/footer branch June 6, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants