Adds automatic commit of Hugo-generated pages changes #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses codeisscience#20. It would have to be way more complicated if new Hugo files had to be checked out. Maybe it's not a big deal, but if that's the case it will print a message so that they can be added manually. I'm kind of wary of adding a push here... You neendn't push after each commit, and it's probably reasonable to just leave the commits there for editing if needed. Also: commits could be squashed... Left as future work and if absolutely necessary.
yochannah
reviewed
May 11, 2018
Collaborator
yochannah
left a comment
yochannah
left a comment
There was a problem hiding this comment.
@JJ Thanks for this! I agree that we shouldn't push after thinking about this - I would be furious if something pushed on my behalf. How do I test? When I checked out I mage a change to a content md and a test commit but I couldn't see any changes. Am I doing it right? :)
Collaborator
Author
|
You sure are. It's just running Hugo, maybe I'm not doing that right...
El vie., 11 may. 2018 15:18, Yo Yehudi <notifications@github.com> escribió:
… ***@***.**** commented on this pull request.
@JJ <https://github.com/JJ> Thanks for this! I agree that we shouldn't
push after thinking about this - I would be furious if something pushed on
my behalf. How do I test? When I checked out I mage a change to a content
md and a test commit but I couldn't see any changes. Am I doing it right? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAB9DE31_39i8eEMGG9r95Ox2fqj9hQks5txY-ygaJpZM4T7ZsR>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of everything in the latest commit. Gist of it is: you might need to add new files generated by Hugo by hand, push is not automatic, but at least a commit with a standard message ("these files have been changed", I know, probably not very good) is generated and saves you some hassle.