-
Notifications
You must be signed in to change notification settings - Fork 32
R googlesheets db implementation #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R googlesheets db implementation #33
Conversation
JJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks basically OK since it's not changing anything that's there, but I'm new to the repo and don't feel comfortable enough for accepting it. Can someone else take a look and/or merge it?
JJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should try and avoid uploading the .DS_Store file.
|
yeah, we need to do a ds store purge and add to the gitignore.
…On Fri, May 11, 2018 at 8:40 AM Juan Julián Merelo Guervós < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Maybe you should try and avoid uploading the .DS_Store file.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#33 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI14jnDQLRJc0XrvHArLGmfE8rOPdrpnks5txUB7gaJpZM4T6e_s>
.
|
|
@yochannah I can add an update once I get in. Would it help if I took a look at #20 next for CI? |
|
@ha0ye yes please! <3 |
|
OK, |
|
it's probably my fault the ds stores were there, then 😂 thanks for fixing
it
…On Fri, May 11, 2018 at 2:38 PM Hao Ye ***@***.***> wrote:
OK, .gitignore already includes .DS_Store, so I think those files in the
repo were present *before* that change. The most recent commit I pushed
to this branch only removes the various .DS_Store files I found under
various directories and subdirectories.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI14jhE1lKVdh94BBfqbxuF5IBj4OOwLks5txZQ-gaJpZM4T6e_s>
.
|
|
@yochannah, I have a .gitignore in my home directory ( |
|
I had totally forgotten that was a thing! Thanks for the tip.
…On Fri, May 11, 2018 at 2:44 PM Hao Ye ***@***.***> wrote:
@yochannah <https://github.com/yochannah>, I have a .gitignore in my home
directory (~) with .DS_Store, which solves the problem of having to add
it to the .gitignore for every project.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI14jvWoWEkQ8EDnkrHj3ggUNixRMyGbks5txZW7gaJpZM4T6e_s>
.
|
|
... done! hopefully I'll stop accidentally dirtying repos from here on :D
…On Fri, May 11, 2018 at 2:45 PM Yo Yehudi ***@***.***> wrote:
I had totally forgotten that was a thing! Thanks for the tip.
On Fri, May 11, 2018 at 2:44 PM Hao Ye ***@***.***> wrote:
> @yochannah <https://github.com/yochannah>, I have a .gitignore in my
> home directory (~) with .DS_Store, which solves the problem of having to
> add it to the .gitignore for every project.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#33 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AI14jvWoWEkQ8EDnkrHj3ggUNixRMyGbks5txZW7gaJpZM4T6e_s>
> .
>
|
|
@ha0ye I am trying to review this PR, but I'm too n00b to R to know how to run the script. Can you give me some pointers? |
|
@yochannah discuss in gitter? |
modifying Rmd to hide messaging from downloading the data from googlesheets
|
Ok, reviewed and looks good! |
Ok, I added some files to try and get at issue #5.
Here's what's going on:
Rfolder contains an R script and an Rmd filestaticfolder (I believe this is the desired destination for it to show up in the Hugo website (eventual URL =www.codeisscience.com/journal_table.html)Some next steps:
In the meantime, you can see a demo here:
https://cdn.rawgit.com/ha0ye/code-is-science/R-googlesheets-DB-implementation/static/journal_table.html
EDIT:
oh yeah, probably needs some tweaking of the formatting!