Skip to content

Conversation

@ha0ye
Copy link
Collaborator

@ha0ye ha0ye commented May 10, 2018

Ok, I added some files to try and get at issue #5.

Here's what's going on:

  • the R folder contains an R script and an Rmd file
  • the R script renders the Rmd file into the final html file and moves it into the static folder (I believe this is the desired destination for it to show up in the Hugo website (eventual URL = www.codeisscience.com/journal_table.html)
  • the Rmd file is the template for the html file, and loads several packages to retrieve the data from google sheets, clean it (namely process the dates), and produce the html widget for the interactive table

Some next steps:

  • check the filenames and edit accordingly
  • publish the original google sheet to the web and update the key in the Rmd file (which currently points towards a copy of the google sheet on my account that I've published to get the API to work)
  • when CI is setup, add the call to run the R script, and make sure the container image has all the necessary packages for building the html file

In the meantime, you can see a demo here:
https://cdn.rawgit.com/ha0ye/code-is-science/R-googlesheets-DB-implementation/static/journal_table.html

EDIT:
oh yeah, probably needs some tweaking of the formatting!

Copy link
Collaborator

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks basically OK since it's not changing anything that's there, but I'm new to the repo and don't feel comfortable enough for accepting it. Can someone else take a look and/or merge it?

JJ
JJ previously requested changes May 11, 2018
Copy link
Collaborator

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should try and avoid uploading the .DS_Store file.

@yochannah
Copy link
Collaborator

yochannah commented May 11, 2018 via email

@ha0ye
Copy link
Collaborator Author

ha0ye commented May 11, 2018

@yochannah I can add an update once I get in. Would it help if I took a look at #20 next for CI?

@yochannah
Copy link
Collaborator

@ha0ye yes please! <3

@ha0ye
Copy link
Collaborator Author

ha0ye commented May 11, 2018

OK, .gitignore already includes .DS_Store, so I think those files in the repo were present before that change. The most recent commit I pushed to this branch only removes the various .DS_Store files I found under various directories and subdirectories.

@yochannah
Copy link
Collaborator

yochannah commented May 11, 2018 via email

@yochannah yochannah dismissed JJ’s stale review May 11, 2018 13:43

now fixed!

@ha0ye
Copy link
Collaborator Author

ha0ye commented May 11, 2018

@yochannah, I have a .gitignore in my home directory (~) with .DS_Store, which solves the problem of having to add it to the .gitignore for every project.

@yochannah
Copy link
Collaborator

yochannah commented May 11, 2018 via email

@yochannah
Copy link
Collaborator

yochannah commented May 11, 2018 via email

@yochannah
Copy link
Collaborator

@ha0ye I am trying to review this PR, but I'm too n00b to R to know how to run the script. Can you give me some pointers?

@ha0ye
Copy link
Collaborator Author

ha0ye commented May 11, 2018

@yochannah discuss in gitter?

modifying Rmd to hide messaging from downloading the data from googlesheets
@ha0ye ha0ye mentioned this pull request May 11, 2018
4 tasks
@yochannah
Copy link
Collaborator

Ok, reviewed and looks good!

@yochannah yochannah merged commit b409fad into codeisscience:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants