Skip to content

Fixes #36#37

Merged
hrahul2605 merged 2 commits intocodeiiest-dev:v2from
01-DC:v2
Jul 19, 2021
Merged

Fixes #36#37
hrahul2605 merged 2 commits intocodeiiest-dev:v2from
01-DC:v2

Conversation

@01-DC
Copy link
Contributor

@01-DC 01-DC commented Jul 19, 2021

Added Pull Request template in .md format

File: .github/pull_request_template.md

@netlify
Copy link

netlify bot commented Jul 19, 2021

‼️ Deploy request for codeiiest rejected.
Learn more about Netlify's sensitive variable policy

🔨 Explore the source changes: d1fd1b5

@sadn1ck
Copy link
Contributor

sadn1ck commented Jul 19, 2021

I am pretty sure templates have to be YAML and not markdown, @hrahul2605 confirm?

@arnabsen1729
Copy link
Member

I am pretty sure templates have to be YAML and not markdown, @hrahul2605 confirm?

@sadn1ck No. Even markdown works. Check docs

@sadn1ck
Copy link
Contributor

sadn1ck commented Jul 19, 2021

Ah cool. LGTM then.

What is stakeholder approval though?

@arnabsen1729
Copy link
Member

Agree with @sadn1ck. Remove the "Stakeholder approval"

@01-DC
Copy link
Contributor Author

01-DC commented Jul 19, 2021

Removed Stakeholder approval from checklist

Copy link
Member

@arnabsen1729 arnabsen1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@hrahul2605 hrahul2605 merged commit 1b40c22 into codeiiest-dev:v2 Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants