Skip to content

[Fix]Events were sorted in ascending order#33

Merged
hrahul2605 merged 2 commits intocodeiiest-dev:v2from
arghya17:arghya
Jul 18, 2021
Merged

[Fix]Events were sorted in ascending order#33
hrahul2605 merged 2 commits intocodeiiest-dev:v2from
arghya17:arghya

Conversation

@arghya17
Copy link
Contributor

I used sort() function and isBefore() method to compare from dayjs module to sort the events in ascending order.

@netlify
Copy link

netlify bot commented Jul 18, 2021

✔️ Deploy Preview for codeiiest ready!

🔨 Explore the source changes: 7d43ccc

🔍 Inspect the deploy log: https://app.netlify.com/sites/codeiiest/deploys/60f44aa06538430008540292

😎 Browse the preview: https://deploy-preview-33--codeiiest.netlify.app/

@arnabsen1729
Copy link
Member

Fixes #32

@arghya17
Copy link
Contributor Author

DeepinScreenshot_20210718203812
Fixed issue screen shot

@arghya17 arghya17 requested a review from arnabsen1729 July 18, 2021 15:42
@arghya17 arghya17 changed the title src/logic/events.ts changed. Events were sorted in ascending order [Fix]Events were sorted in ascending order Jul 18, 2021
@arghya17 arghya17 requested a review from raydwaipayan July 18, 2021 16:03
Copy link
Collaborator

@raydwaipayan raydwaipayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrahul2605 hrahul2605 merged commit 4f320c6 into codeiiest-dev:v2 Jul 18, 2021
@arghya17 arghya17 deleted the arghya branch July 19, 2021 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants