Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to CI 4.4.2 #215

Merged
merged 16 commits into from
Oct 27, 2023
Merged

Update to CI 4.4.2 #215

merged 16 commits into from
Oct 27, 2023

Conversation

kenjis
Copy link
Contributor

@kenjis kenjis commented Oct 23, 2023 •
edited
Loading

  • add tatter/patches
  • update app/
  • update to CI 4.4.2
  • update github workflows

kenjis added 5 commits October 23, 2023 16:21
@kenjis
chore: composer require --dev tatter/patches
3587c42
@kenjis
chore: remove codeigniter4/devkit temporarily
1deb3f1
@kenjis
Patch framework (v4.2.0 => v4.4.2)
b2ec09b 
 Conflicts:
	Controllers/Home.php
	Views/welcome_message.php
	app/Config/ContentSecurityPolicy.php
	app/Config/Kint.php
	app/Config/Paths.php
	app/Config/Routes.php
	app/Config/Routing.php
	app/Config/Session.php
	app/Views/errors/html/error_exception.php
@kenjis
chore: restore codeigniter4/devkit
e6824e1
@kenjis
chore: composer update (by PHP 7.4)
88ed97a
@kenjis kenjis marked this pull request as draft October 23, 2023 07:41
@kenjis
Copy link
Contributor Author

kenjis commented Oct 23, 2023

Why error?

Run composer-unused -vvv --output-format=github --ansi --no-interaction --no-progress
  

Box Requirements Checker
========================

> Using PHP 8.1.24
> PHP is using the following php.ini file:
  /etc/php/8.1/cli/php.ini

> Checking Box requirements:
  ✔ The application requires the version "^7.4 || ^8.0" or greater.
  ✔ The application requires the extension "json".
  ✔ The package "nikic/php-parser" requires the extension "tokenizer".
  
                                                                                
 [OK] Your system is ready to run the application.                              
                                                                                

::error file=/home/runner/work/playground/playground/composer.json,line=25,col=0::php is unused
file=/home/runner/work/playground/playground/composer.json,line=26,col=0::codeigniter4/framework was ignored
Error: Process completed with exit code 1.

@kenjis
chore: igonre 'php'
2e5ff62 
I don't know why this is needed.
@kenjis kenjis marked this pull request as ready for review October 23, 2023 08:52
@MGatner
Copy link
Collaborator

MGatner commented Oct 23, 2023

That "PHP is unused" error keeps coming back 🙄 Ignoring it is a good workaround.

@MGatner
Copy link
Collaborator

MGatner commented Oct 23, 2023

Typo in your last commit message, FYI

MGatner
MGatner approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@MGatner MGatner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I flipped through the changes but I'm going to trust Patches and the pipeline on this.

@kenjis kenjis merged commit 2fbe98d into codeigniter4projects:develop Oct 27, 2023
28 checks passed
@kenjis kenjis deleted the update-ci-442 branch October 27, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner