fix: unauthorized users for groups and permissions are not redirected to the previous url #799
Conversation
|
Thanks @datamweb. Feel free to check when you can. |
|
The option for adding arguments to filter configuration has been added to CI v4.4.0, see docs. This PR might need to be updated to either:
WDYT? |
Yes, I remembered, I had reviewed this one😀.
Shield requires CodeIgniter 4.2.7+ at this point I am not very inclined to upgrade to 4.4.0. |
|
Hi @kenjis, @lonnieezell, @MGatner can you take a look? |
|
@sammyskills is aware of this, I haven't played with the code yet, I'll try to do it tomorrow. |
| $session = session(); | ||
| $session->setTempdata('beforeLoginUrl', current_url(), 300); |
There was a problem hiding this comment.
I just came up with this code, but it is a copy and paste.
Since it is the same knowledge (save the URL for 300 seconds in the session), it might be better to put it together in a method if possible.
But there doesn't seem to be an appropriate class to put it in now.
There was a problem hiding this comment.
Yes, I'm currently merge this. Maybe we can refactor later.
There was a problem hiding this comment.
@sammyskills I came back after a million days 😃. Sorry.
Thank you!
Fixes #798