Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt-BR #615

Closed
wants to merge 42 commits into from
Closed

pt-BR #615

wants to merge 42 commits into from

Conversation

caosdp-rs
Copy link
Contributor

@caosdp-rs caosdp-rs commented Feb 1, 2023

Supersedes #613

@kenjis kenjis added the lang Languages file label Feb 1, 2023
@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Feb 1, 2023
@@ -66,7 +66,7 @@ abstract class AbstractTranslationTestCase extends TestCase
// NorwegianTranslationTest::class => 'no',
// PolishTranslationTest::class => 'pl',
// PortugueseTranslationTest::class => 'pt',
// BrazilianTranslationTest::class => 'pt-BR',
BrazilianTranslationTest::class => 'pt-BR',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BrazilianTranslationTest::class => 'pt-BR',
BrazilianTranslationTest::class => 'pt-BR',

@datamweb
Copy link
Collaborator

datamweb commented Feb 1, 2023

Hello.
Thanks for the PR and welcome to Shield.

Please sign all your commits.
Screenshot 2023-02-01 181020

Also, we have the error Code Style, to fix it, you can run the following command:

composer cs-fix 

@datamweb
Copy link
Collaborator

datamweb commented Feb 1, 2023

Hi @kenjis,
The question is, why have we used the namespace in the language file! I didn't see any explanation in the documentation about using the namespace for the languages file.
See https://codeigniter.com/user_guide/outgoing/localization.html#id6

Edit:

if you are using the locale fr-CA, then a localized message will first be sought in Language/fr/CA, then in Language/fr, and finally in Language/en.

https://codeigniter.com/user_guide/outgoing/localization.html#id8

kenjis and others added 19 commits February 1, 2023 21:06
mkdocs needs <> plain URL.
$filters cannot set filer aruguments.
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Co-authored-by: Pooya Parsa Dadashi <pooya_parsa_dadashi@yahoo.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
@kenjis
Copy link
Member

kenjis commented Feb 2, 2023

@datamweb Setting namespace in lang files is a mistake.

I sent PR codeigniter4/CodeIgniter4#7210

Comment on lines 4 to 6


namespace CodeIgniter\Shield\Language\pt-BR;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these lines.

@kenjis
Copy link
Member

kenjis commented Feb 2, 2023

@caosdp-rs It seems you added commits that you didn't make.
Please run git rebase to update your PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

@kenjis kenjis removed the GPG-Signing needed Pull requests that need GPG-Signing label Feb 2, 2023
@kenjis
Copy link
Member

kenjis commented Feb 2, 2023

There are 4 failing checks in GitHub Actions.
Please fix them.

And I would like you to git rebase not git merge if you can.

@caosdp-rs
Copy link
Contributor Author

caosdp-rs commented Feb 2, 2023

There are 4 failing checks in GitHub Actions. Please fix them.

And I would like you to git rebase not git merge if you can.

PS C:\candre\shield> git rebase
error: cannot rebase: You have unstaged changes.
error: Please commit or stash them.

PS C:\candre\shield> git add .
warning: in the working copy of 'src/Language/pt-BR/Auth.php', LF will be replaced by CRLF the next time Git touches it
PS C:\candre\shield> git commit -m "Teste."
gpg: WARNING: server 'gpg-agent' is older than us (2.2.27-unknown < 2.2.29-unknown)
gpg: Note: Outdated servers may lack important security fixes.
gpg: Note: Use the command "gpgconf --kill all" to restart them.
[develop b051b5a] Teste.
1 file changed, 2 insertions(+), 3 deletions(-)
PS C:\candre\shield> git rebase
Current branch develop is up to date.

@kenjis
Copy link
Member

kenjis commented Feb 2, 2023

> git fetch upstream
> git switch develop
> git rebase upstream/develop

@caosdp-rs
Copy link
Contributor Author

git rebase upstream/develop

PS C:\candre\shield> git remote add upstream https://github.com/codeigniter4/shield.git
PS C:\candre\shield> git fetch upstream
remote: Enumerating objects: 84, done.
remote: Counting objects: 100% (28/28), done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 84 (delta 17), reused 18 (delta 17), pack-reused 56
Unpacking objects: 100% (84/84), 528.47 KiB | 1.06 MiB/s, done.
From https://github.com/codeigniter4/shield

  • [new branch] develop -> upstream/develop
  • [new branch] gh-pages -> upstream/gh-pages
  • [new branch] master -> upstream/master
  • [new tag] v1.0.0-beta -> v1.0.0-beta
  • [new tag] v1.0.0-beta.2 -> v1.0.0-beta.2
  • [new tag] v1.0.0-beta.3 -> v1.0.0-beta.3
    PS C:\candre\shield> git switch develop
    Already on 'develop'
    M tests/Language/BrazilianTranslationTest.php
    Your branch is up to date with 'origin/develop'.
    PS C:\candre\shield> git rebase upstream/develop
    error: cannot rebase: You have unstaged changes.
    error: Please commit or stash them.

@kenjis
Copy link
Member

kenjis commented Feb 2, 2023

> git stash
> git rebase upstream/develop

If you want to get back your local changes:

> git stash pop

kenjis and others added 16 commits February 2, 2023 03:36
$filters cannot set filer aruguments.
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Co-authored-by: Pooya Parsa Dadashi <pooya_parsa_dadashi@yahoo.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Signed-off-by: caosdp-rs <caosdp@gmail.com>
Comment on lines +132 to +134
<<<<<<< HEAD
<<<<<<< HEAD
=======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

Comment on lines +146 to +148
>>>>>>> 39f1a58 (docs: make file paths bold)
=======
>>>>>>> 9981e4e (docs: remove unsupported code sample)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang Languages file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants