Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Force password reset #601

Merged
merged 25 commits into from
Feb 3, 2023
Merged

Feat: Force password reset #601

merged 25 commits into from
Feb 3, 2023

Conversation

sammyskills
Copy link
Contributor

Fixes #522

Implemented the force password reset functionality with the following highlights:

  • Added a new Resettable trait that is used on the User entity. This provides a couple of methods to check if a user requires a password reset or not, forcing a password reset and undoing the forced password reset. Thanks @lonnieezell
  • Updated the UserIdentityModel with methods to force a password reset for multiple users and globally, i.e., all the users.
  • Added a filter ForcePasswordResetFilter to check and redirect appropriately after a user is logged in.
  • Updated the Registrar config.
  • Updated Auth config to allow devs to specify a force_reset redirect.
  • Updated quickstart.md and install.md docs.
  • And of course, created and updated tests.

@kenjis kenjis added the new feature PRs for new features label Jan 16, 2023
@kenjis
Copy link
Member

kenjis commented Jan 18, 2023 •
edited
Loading

Tests do not pass on Postgres.

There were 6 errors:

1) Tests\Unit\UserIdentityModelTest::testForceMultiplePasswordReset
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  operator does not exist: smallint = boolean
LINE 3: AND "force_reset" = FALSE
                          ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:645
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Models/UserIdentityModel.php:345
/home/runner/work/shield/shield/tests/Unit/UserIdentityModelTest.php:96
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  operator does not exist: smallint = boolean
LINE 3: AND "force_reset" = FALSE
                          ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:152
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Models/UserIdentityModel.php:345
/home/runner/work/shield/shield/tests/Unit/UserIdentityModelTest.php:96
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
ErrorException: pg_query(): Query failed: ERROR:  operator does not exist: smallint = boolean
LINE 3: AND "force_reset" = FALSE
                          ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:147
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Models/UserIdentityModel.php:345
/home/runner/work/shield/shield/tests/Unit/UserIdentityModelTest.php:96
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

2) Tests\Authentication\ForcePasswordResetTest::testRequiresPasswordResetRedirect
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:645
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Traits/Resettable.php:43
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:96
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:152
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Traits/Resettable.php:43
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:96
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
ErrorException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:147
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Traits/Resettable.php:43
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:96
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

3) Tests\Authentication\ForcePasswordResetTest::testForceGlobalPasswordReset
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  operator does not exist: smallint = boolean
LINE 4: AND "force_reset" = FALSE
                          ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:645
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Models/UserIdentityModel.php:369
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:125
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  operator does not exist: smallint = boolean
LINE 4: AND "force_reset" = FALSE
                          ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:152
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Models/UserIdentityModel.php:369
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:125
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
ErrorException: pg_query(): Query failed: ERROR:  operator does not exist: smallint = boolean
LINE 4: AND "force_reset" = FALSE
                          ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:147
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Models/UserIdentityModel.php:369
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:125
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

4) Tests\Authentication\ForcePasswordResetTest::testUserRequiresPasswordReset
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:645
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:59
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:152
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:59
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
ErrorException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:147
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:59
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

5) Tests\Authentication\ForcePasswordResetTest::testForcePasswordResetOnUser
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:645
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Traits/Resettable.php:43
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:71
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:152
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Traits/Resettable.php:43
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:71
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
ErrorException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:147
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Traits/Resettable.php:43
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:71
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

6) Tests\Authentication\ForcePasswordResetTest::testUndoForcePasswordResetOnUser
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:645
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Traits/Resettable.php:43
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:83
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
CodeIgniter\Database\Exceptions\DatabaseException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:152
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Traits/Resettable.php:43
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:83
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

Caused by
ErrorException: pg_query(): Query failed: ERROR:  column "force_reset" is of type smallint but expression is of type boolean
LINE 1: UPDATE "db_auth_identities" SET "force_reset" = TRUE, "updat...
                                                        ^
HINT:  You will need to rewrite or cast the expression.

/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/Postgre/Connection.php:147
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:691
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php:605
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseBuilder.php:2462
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:395
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Model.php:755
/home/runner/work/shield/shield/src/Traits/Resettable.php:43
/home/runner/work/shield/shield/tests/Authentication/ForcePasswordResetTest.php:83
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:97

ERRORS!
Tests: 227, Assertions: 575, Errors: 6.

https://github.com/codeigniter4/shield/actions/runs/3933401851/jobs/6727065311

@kenjis
Copy link
Member

kenjis commented Jan 18, 2023

Rector check failed.
https://github.com/codeigniter4/shield/actions/runs/3933401858/jobs/6727064018

Please run rector to fix them.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#static-analysis-on-php-code

@kenjis
Copy link
Member

kenjis commented Jan 20, 2023

Test does not pass.
See https://github.com/codeigniter4/shield/actions/runs/3965102057/jobs/6794519880

@sammyskills
Copy link
Contributor Author

The test passed now. Please check.

kenjis
kenjis reviewed Jan 21, 2023
View reviewed changes
docs/install.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Jan 21, 2023
View reviewed changes
docs/install.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Jan 21, 2023
View reviewed changes
docs/install.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Jan 21, 2023
View reviewed changes
docs/install.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Jan 21, 2023
View reviewed changes
docs/install.md Outdated Show resolved Hide resolved
@sammyskills
Copy link
Contributor Author

Hi @kenjis,

Still waiting for your review.

kenjis
kenjis reviewed Jan 30, 2023
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Jan 30, 2023
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Jan 30, 2023
View reviewed changes
docs/quickstart.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Jan 30, 2023
View reviewed changes
src/Traits/Resettable.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Jan 30, 2023
View reviewed changes
src/Traits/Resettable.php Outdated Show resolved Hide resolved
@sammyskills
updated auth config, added force_reset redirect
320e4d4
@sammyskills
added ForcePasswordResetFilter
415edf8
@sammyskills
updated registrar config, added the force-reset filter
f36a46b
@sammyskills
created Tests: ForcePasswordResetTest
8812d40
@sammyskills
updated Tests: UserIdentityModelTest
947705d
@sammyskills
updated docs:install.md, added force password reset explanation
0d2f89a
@sammyskills
apply suggestions from code review: removed testForceGlobalPasswordRe…
066126e 
…set() from UserIdentityModelTest
@sammyskills
fixed Postgres test failure
268018f
@sammyskills
fixed Rector Analysis failure
7f68d02
@sammyskills
rebased docs:install.md
8159ea6
@sammyskills
fixed checks
8b45094
@sammyskills
fixed postgres test failure - b2
7c044fa
@sammyskills
updated docs:install.md
7c94a67
@sammyskills
forceGlobalPasswordReset() no longer excludes the logged in user
7e77fd4
@sammyskills
reduced test users to 50
0621000
@sammyskills
added the unique() faker modifier to prevent duplicates
2a4d1c3
@sammyskills
applied code review suggestions on code files
482c715
@sammyskills
applied code review suggestions on docs
03351e0
@sammyskills
fixed phpstan error
491b0d2
@sammyskills
fixed phpstan error - 2
f61a5b3
@sammyskills
fixed phpstan error -3
1b406e4
@sammyskills
applied code review suggestion on tests and auth config file
83baaa8
@kenjis kenjis merged commit 2263f82 into codeigniter4:develop Feb 3, 2023
@kenjis
Copy link
Member

kenjis commented Feb 3, 2023

@sammyskills Thank you!

@sammyskills sammyskills deleted the force-password-reset branch February 3, 2023 05:32
@kenjis kenjis mentioned this pull request Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
new feature PRs for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev: force password reset functionality
2 participants
@sammyskills @kenjis