Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unnamed Auth routes returns an error when inside a route group #577

Merged
merged 21 commits into from
Jan 10, 2023
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated installation docs to explain filter configuration for grouped…
… routing.
  • Loading branch information
sammyskills committed Jan 6, 2023
commit 5a21c305bdbbb8107cd75e5d5b02c5000dd2623e
21 changes: 21 additions & 0 deletions docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -240,3 +240,24 @@ public $filters = [
]
];
```

> **Note** If you have grouped or changed the default format of the routes, ensure that your code matches the new format(s) in the `App/Config/Filter.php` file.

For example, if you configured your routes like so:

```php
$routes->group('accounts', static function($routes) {
service('auth')->routes($routes);
});
```
Then the global `before` filter for `session` should look like so:

```php
public $globals = [
'before' => [
// ...
'session' => ['except' => ['accounts/login*', 'accounts/register', 'accounts/auth/a/*']]
]
]
```
The same should apply for the Rate Limiting.