Repository navigation
feat: notify devs when user has used magic link login. - #413
Merged
Merged
Conversation
kenjis
reviewed
Aug 31, 2022
MGatner
requested changes
Aug 31, 2022
MGatner
left a comment
MGatner
left a comment
Member
There was a problem hiding this comment.
I'm not opposed to the session variable, but why not just trigger an Event? Or do both?
Member
|
Can you use |
kenjis
reviewed
Sep 2, 2022
Member
Author
|
Doc changes pushed. |
Co-authored-by: MGatner <mgatner@icloud.com>
kenjis
force-pushed
the
magic-link-notice
branch
from
September 9, 2022 08:40
02b11be to
bb9c1fd
Compare
Member
|
Rebased and force pushed. |
datamweb
approved these changes
Sep 9, 2022
datamweb
left a comment
datamweb
left a comment
Collaborator
There was a problem hiding this comment.
The test did not cover event magicLogin!
Other items are good.
datamweb
requested changes
Sep 10, 2022
Co-authored-by: Pooya Parsa Dadashi <pooya_parsa_dadashi@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a temp session variable to allow developers to respond as they choose whenever a user has completed a magic link login.