Skip to content

chore: add language unit tests #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2022
Merged

chore: add language unit tests #274

merged 4 commits into from
Jul 4, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 2, 2022 •
edited
Loading

  • add language unit tests workflow

I tested on my repository: kenjis#1

Run vendor/bin/phpunit --verbose --no-coverage --testsuite lang
PHPUnit 9.5.21 #StandWithUkraine
Runtime:       PHP 8.0.20
Configuration: /home/runner/work/codeigniter-shield/codeigniter-shield/phpunit.xml.dist
Random Seed:   1656800527
.....................                                             21 / 21 (100%)
Time: 00:00.026, Memory: 10.00 MB
OK (21 tests, 21 assertions)

@kenjis kenjis added the github_actions Pull requests that update GitHub Actions code label Jul 2, 2022
@datamweb
Copy link
Collaborator

datamweb commented Jul 3, 2022

I thought this had been covered before! I really like this PR.

MGatner
MGatner requested changes Jul 3, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@kenjis @MGatner
chore: change PHP version
0f5fe5e 
Co-authored-by: MGatner <mgatner@icloud.com>
@kenjis kenjis merged commit 2abb23e into codeigniter4:develop Jul 4, 2022
@kenjis kenjis deleted the update-workflows-phpunit.yml branch July 4, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @datamweb @lonnieezell @MGatner