Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: [nl] fix incorrect translation #1231

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

christianberkman
Copy link
Contributor

@christianberkman christianberkman commented Nov 16, 2024

Key rememberMe currently is "Wachtwoord onthouden" but this translates to "Remember password". Better translation of "Remember me?" would be "Blijf ingelogd" (stay logged in).

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Key rememberMe currently is "Wachtwoord onthouden" but this translates to "Remember password". Better translation of "Remember me?" would be "Blijf ingelogd" (remain logged in).
@datamweb datamweb changed the title [nl] fix: incorrect translation lang: [nl] fix incorrect translation Nov 18, 2024
@datamweb datamweb added the lang Languages file label Nov 18, 2024
@@ -53,7 +53,7 @@
// Login
'login' => 'Inloggen',
'needAccount' => 'Heb je nog geen account?',
'rememberMe' => 'Wachtwoord onthouden',
'rememberMe' => 'Ingelogd blijven',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NotCoffee418 Can you comment here, please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a better translation to me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🎉

@datamweb datamweb merged commit b2ddb70 into codeigniter4:develop Nov 18, 2024
38 checks passed
@christianberkman christianberkman deleted the patch-1 branch November 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang Languages file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants