Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unneeded Entities\Cast\IntBoolCast #1187

Closed
wants to merge 1 commit into from

Conversation

grimpirate
Copy link
Contributor

Description
Reopening of Pull Request #1186 as I deleted the repository prematurely.

@kenjis kenjis added the refactor Pull requests that refactor code label Aug 27, 2024
@kenjis
Copy link
Member

kenjis commented Aug 27, 2024

Thank you for sending this PR.
Please fix all errors in GitHub Actions.
If you have questions, feel free to ask.

@grimpirate
Copy link
Contributor Author

@kenjis The unsuccessful checks appear to be during phpstan and rector complaining that they can no longer find the IntBoolCast and Entity classes. Those are unneeded and therefore deleted. Not sure how to fix the GitHub actions.

@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Aug 27, 2024
@kenjis
Copy link
Member

kenjis commented Aug 27, 2024

The commit is not GPG signed. Please sign all commits.
See #1117 (comment)

@grimpirate
Copy link
Contributor Author

@kenjis I'll have to open a new PR. I used the web editor and was trying to squash the php stan edits as I couldn't do it on the web. Sorry about that.

@kenjis
Copy link
Member

kenjis commented Aug 27, 2024

Okay, no problem.

But I recommend you learn how to use:

  • git command
  • your IDE

If you learn them, you could manipulate git commits freely and easily on your local machine.

  • remove existing commits and add new commits
  • modify existing commits
  • update your PR branch
  • create multiple PRs at the same time
  • check out other's PR code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GPG-Signing needed Pull requests that need GPG-Signing refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants