-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lang: [nl] fix missing translation #1165
Conversation
@@ -25,7 +25,7 @@ | |||
'badToken' => 'Ongeldige toegangstoken.', | |||
'oldToken' => 'Vervallen toegangstoken.', | |||
'noUserEntity' => 'Gebruikersentiteit moet worden opgegeven voor wachtwoordvalidatie.', | |||
'invalidEmail' => '(To be translated) Unable to verify the email address matches the email "{0}".', | |||
'invalidEmail' => 'Het e-mailadres "{0}" kon niet geverifieerd worden.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christianberkman How about this?
'invalidEmail' => 'Het e-mailadres "{0}" kon niet geverifieerd worden.', | |
'invalidEmail' => 'Kan niet bevestigen dat het e-mailadres "{0}" overeenkomt met het opgegeven e-mailadres.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I have not used this functionality and the message puzzles me a bit. What is the context for this message? Password recovery? Then your suggestion makes sense, altough I would then I would add
"... het opgegeven e-mailadres voor deze gebruiker" which would be ".. matches the email for this user".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text is not used to recover the password, but to log the user in via the magic link.
The magic link allows the user to temporarily enter it and then set a new password.
In any case, I think that the translation of a subject should be as close as possible to the original subject. Nothing should be added or taken away from it. Of course, I understand that sometimes it is difficult to do such a thing in translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NotCoffee418 Can you help please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a problem with the english version in the first place.
Literal translation:
Kan niet verifiëren dat het e-mailadres overeenkomt met het e-mailadres "{0}"
Preferably, I'd go with:
Kan niet verifiëren dat het e-mailadres overeenkomt met "{0}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"E-mail {0} is not associated with this account" seems to be a bit different.
What is the "this account"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From your example:
- "The e-mail address" refers to the e-mail in the databse, but that is not revealed.
- {0} refers to "not.exist@example.jp"
I think most users would assume "The e-mail address" is what they have just entered in the form, so they could interpert the error message as "Unable to verify [not.exist@example.jp] matches the e-mail not.exist@example.jp". That is confusing. Hence I would suggest
"Unable to verify {0} is associated with any registered user" (or user account, etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line was Unable to verify the email address matches the email on record.
50591b5
So the following is correct?
- Unable to verify the email address "not.exist@example.jp" matches the email on record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it is correct. Could argue still for "any email" as we have more than one email on record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent PR #1175
Description
Translated an untranslated key in
Language/NL
Checklist: