Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix method names with incorrect case #1163

Merged
merged 1 commit into from
Aug 16, 2024
Merged

refactor: fix method names with incorrect case #1163

merged 1 commit into from
Aug 16, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 12, 2024

Description

  • fix method names

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Aug 12, 2024
@kenjis kenjis force-pushed the refactor-method-incorrect-case branch from 176fd94 to 317477e Compare August 12, 2024 08:24
datamweb
datamweb approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactored demonstrates the highest level of insight in PR.

Nice!

@kenjis kenjis merged commit d3b9285 into codeigniter4:develop Aug 16, 2024
34 checks passed
@kenjis kenjis deleted the refactor-method-incorrect-case branch August 16, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @datamweb