Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix incorrect condition in AbstractTranslationTestCase #1153

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 7, 2024

Description
Fix the following error.

 ------ -----------------------------------------------------------------------
  Line   tests/Language/AbstractTranslationTestCase.php
 ------ -----------------------------------------------------------------------
  327    Strict comparison using === between array{list<non-empty-string>} and
         array{} will always evaluate to false.
         💡 Because the type is coming from a PHPDoc, you can turn off this
            check by setting treatPhpDocTypesAsCertain: false in your
            phpstan.neon.dist.
 ------ -----------------------------------------------------------------------

https://github.com/codeigniter4/shield/actions/runs/10269040515/job/28413552557?pr=1152

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

 ------ -----------------------------------------------------------------------
  Line   tests/Language/AbstractTranslationTestCase.php
 ------ -----------------------------------------------------------------------
  327    Strict comparison using === between array{list<non-empty-string>} and
         array{} will always evaluate to false.
         💡 Because the type is coming from a PHPDoc, you can turn off this
            check by setting treatPhpDocTypesAsCertain: false in your
            phpstan.neon.dist.
 ------ -----------------------------------------------------------------------
@kenjis kenjis added the testing Pull requests that changes tests only label Aug 7, 2024
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need to update the paths variable in phpunit-lang Github Actions by adding tests/Language/AbstractTranslationTestCase.php to see the changes applied.

@datamweb
Copy link
Collaborator

datamweb commented Aug 7, 2024

@kenjis thanks.

@datamweb datamweb merged commit 7a118f3 into codeigniter4:develop Aug 7, 2024
35 checks passed
@kenjis kenjis deleted the fix-AbstractTranslationTestCase branch August 7, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants