Skip to content

refactor: Superglobals - remove property promotion and fix PHPDocs #9871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulbalandan merged 1 commit into from
Jan 6, 2026
+38 −8
Merged

refactor: Superglobals - remove property promotion and fix PHPDocs #9871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 38 additions & 8 deletions system/Superglobals.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,36 @@
*/
final class Superglobals
{
/**
* @var array<string, server_items>
*/
private array $server = [];

/**
* @var array<string, get_items>
*/
private array $get = [];

/**
* @var array<string, post_items>
*/
private array $post = [];

/**
* @var array<string, cookie_items>
*/
private array $cookie = [];

/**
* @var array<string, files_items>
*/
private array $files = [];

/**
* @var array<string, request_items>
*/
private array $request = [];

/**
* @param array<string, server_items>|null $server
* @param array<string, get_items>|null $get
Expand All @@ -51,12 +81,12 @@ final class Superglobals
* @param array<string, request_items>|null $request
*/
public function __construct(
private ?array $server = null,
private ?array $get = null,
private ?array $post = null,
private ?array $cookie = null,
private ?array $files = null,
private ?array $request = null,
?array $server = null,
?array $get = null,
?array $post = null,
?array $cookie = null,
?array $files = null,
?array $request = null,
) {
$this
->setServerArray($server ?? $_SERVER)
Expand Down Expand Up @@ -360,7 +390,7 @@ public function setRequestArray(array $array): self
/**
* Get all $_FILES values.
*
* @return files_items
* @return array<string, files_items>
*/
public function getFilesArray(): array
{
Expand All @@ -370,7 +400,7 @@ public function getFilesArray(): array
/**
* Set the entire $_FILES array.
*
* @param files_items $array
* @param array<string, files_items> $array
*/
public function setFilesArray(array $array): self
{
Expand Down
Loading