fix: encapsulation violation in BasePreparedQuery
class
#9603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an encapsulation violation where
BasePreparedQuery
was directly accessing the protected propertyBaseConnection::$transStatus
, which goes against PHP’s visibility rules.To resolve this, I introduced a new internal method,
BaseConnection::handleTransStatus()
, which provides controlled access for modifying the transaction status when a query fails during an active transaction.The issue was originally spotted in the forum: https://forum.codeigniter.com/showthread.php?tid=93029
Checklist: