-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add page start end total to PagerRenderer
#9371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
paulbalandan
merged 8 commits into
codeigniter4:4.6
from
murilohpucci:feature-add-page-start-end-total-to-page-renderer
Jan 7, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7225338
Add some methods to the page renderer to make easier to
murilohpucci fa9bf84
Add type hint to the new per page variable on the page renderer.
murilohpucci f369cb9
Create more tests for the page start and end, and improve the comment…
murilohpucci 9878718
Add a documentation and also improve some comments.
murilohpucci ce162e2
Use version added instead of warning on the documentation
murilohpucci 2247191
Add changelog.
murilohpucci 5b84594
Fix CR issues.
murilohpucci ae13ba5
Add null as the default value for perPageStart and End
murilohpucci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<?php $pager->setSurroundCount(1) ?> | ||
|
||
<p> | ||
Showing <span class="font-medium"><?= $pager->getPerPageStart() ?></span> | ||
to <span class="font-medium"><?= $pager->getPerPageEnd() ?></span> | ||
of <span class="font-medium"><?= $pager->getTotal() ?></span> results | ||
</p> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.