Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: BaseBuilder #9157

Merged
merged 3 commits into from
Aug 30, 2024
Merged

refactor: BaseBuilder #9157

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87acaf7
docs: update comment
kenjis Aug 28, 2024
694b031
fix: remove uneeded if condition
kenjis Aug 28, 2024
9e97a0c
refactor: break long lines
kenjis Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: break long lines
  • Loading branch information
@kenjis
kenjis committed Aug 28, 2024
commit 9e97a0c6d444400630976df3c61ecea236b9bd3c
10 changes: 8 additions & 2 deletions system/Database/BaseBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3164,8 +3164,14 @@ protected function compileWhereHaving(string $qbKey): string
);

foreach ($conditions as &$condition) {
if (($op = $this->getOperator($condition)) === false
|| ! preg_match('/^(\(?)(.*)(' . preg_quote($op, '/') . ')\s*(.*(?<!\)))?(\)?)$/i', $condition, $matches)
$op = $this->getOperator($condition);
if (
$op === false
|| ! preg_match(
'/^(\(?)(.*)(' . preg_quote($op, '/') . ')\s*(.*(?<!\)))?(\)?)$/i',
$condition,
$matches
)
) {
continue;
}
Expand Down
Loading