Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable AddMethodCallBasedStrictParamTypeRector #9156

Conversation

samsonasik
Copy link
Member

Description

Change private method param type to strict type, based on passed strict types via AddMethodCallBasedStrictParamTypeRector

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik samsonasik force-pushed the refactor-enable-add-method-call-based-param branch from 854e3db to 6b1f135 Compare August 28, 2024 01:51
@samsonasik samsonasik force-pushed the refactor-enable-add-method-call-based-param branch from 6b1f135 to 87eb71c Compare August 28, 2024 01:55
@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Thank you @paulbalandan for the review, let's merge 👍

@samsonasik samsonasik merged commit 68d2fed into codeigniter4:develop Aug 28, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-enable-add-method-call-based-param branch August 28, 2024 03:19
@kenjis kenjis mentioned this pull request Aug 28, 2024
5 tasks
@kenjis kenjis added the refactor Pull requests that refactor code label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants