Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix doc comments for Router #9151

Merged
merged 2 commits into from
Aug 30, 2024
Merged

docs: fix doc comments for Router #9151

merged 2 commits into from
Aug 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 27, 2024

Description

  • small fix

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

datamweb
datamweb approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the controller class.

@kenjis
Copy link
Member Author

kenjis commented Aug 27, 2024

It returns "Controller classname or Closure", but I don't know why this method needs to return.
Because we have controllerName() for that purpose.

@kenjis kenjis changed the title docs: fix doc comment for Router::handle() docs: fix doc comments for Router::handle() Aug 27, 2024
@kenjis kenjis changed the title docs: fix doc comments for Router::handle() docs: fix doc comments for Router Aug 27, 2024
@kenjis kenjis merged commit 77f5e47 into codeigniter4:develop Aug 30, 2024
41 checks passed
@kenjis kenjis deleted the fix-comment-Router.php branch August 30, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb