Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor CS scripts #9066

Merged
merged 2 commits into from
Jul 25, 2024
Merged

chore: refactor CS scripts #9066

merged 2 commits into from
Jul 25, 2024

Conversation

paulbalandan
Copy link
Member

Description

  • Use php-cs-fixer check as shorthand for php-cs-fixer fix --dry-run
  • Call composer cs instead of individual calls

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis
kenjis approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Jul 25, 2024
@paulbalandan paulbalandan merged commit d62477d into codeigniter4:develop Jul 25, 2024
40 checks passed
@paulbalandan paulbalandan deleted the coding-style-scripts branch July 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @kenjis