Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RedisHandler::deleteMatching() not deleting matching keys if cache prefix is used #8952

Merged
merged 7 commits into from
Jun 14, 2024
Merged

fix: RedisHandler::deleteMatching() not deleting matching keys if cache prefix is used #8952

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7f15535
Combine similar deleteMatching test cases
paulbalandan Jun 10, 2024
3b7046a
Add failing test for cache prefix
paulbalandan Jun 10, 2024
e86b75a
Fix rector transform
paulbalandan Jun 10, 2024
9099e20
Validate pattern against prefix
paulbalandan Jun 10, 2024
3d5b97d
refactor RedisHandler::deleteMatching()
paulbalandan Jun 10, 2024
766df8c
Add comments to each data
paulbalandan Jun 12, 2024
cb23bdb
Remove space
paulbalandan Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove space
  • Loading branch information
@paulbalandan
paulbalandan authored Jun 12, 2024
commit cb23bdb1cf92b29e15ed536b05f7cfaf71e7dc60
2 changes: 1 addition & 1 deletion tests/system/Cache/Handlers/RedisHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public static function provideDeleteMatching(): iterable
// key_1, key_10, key_11, key_12, key_13, key_14, key_15, key_16, key_17, key_18, key_19, key_100, key_101
yield 'prefix' => ['key_1*', 13];

// Given the key "*1", deleteMatching() should delete 11 keys:
// Given the key "*1", deleteMatching() should delete 11 keys:
// key_1, key_11, key_21, key_31, key_41, key_51, key_61, key_71, key_81, key_91, key_101
yield 'suffix' => ['*1', 11];

Expand Down
Loading