Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TypeError in number_to_amount() #8932

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix: TypeError in number_to_amount() #8932

merged 2 commits into from
Jun 4, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 2, 2024 •
edited
Loading

Description
From https://forum.codeigniter.com/showthread.php?tid=90996

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
test: add test cases
10a0739
@kenjis
fix: TypeError in number_to_amount()
3d6436e 
TypeError: str_replace(): Argument #3 ($subject) must be of type array|string, int given
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 2, 2024
@kenjis kenjis merged commit 4dd9a87 into codeigniter4:develop Jun 4, 2024
41 checks passed
@kenjis kenjis deleted the fix-number-helper-type-error branch June 4, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevsr ddevsr ddevsr approved these changes

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @michalsn @datamweb @ddevsr