Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support database name with dots #8664

Merged
merged 12 commits into from
Mar 28, 2024
Merged

feat: support database name with dots #8664

merged 12 commits into from
Mar 28, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 26, 2024 •
edited
Loading

Description
Closes #8647

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Mar 26, 2024
@kenjis kenjis marked this pull request as draft March 26, 2024 10:45
@kenjis kenjis force-pushed the feat-database-name-with-dot branch 3 times, most recently from 4ea6683 to 5dd950c Compare March 27, 2024 01:14
@kenjis kenjis mentioned this pull request Mar 27, 2024
Closed
@kenjis kenjis marked this pull request as ready for review March 27, 2024 02:59
michalsn
michalsn approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work well 👍

ddevsr
ddevsr reviewed Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@ddevsr ddevsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add notes support dot in database since 4.5

@kenjis kenjis added the database Issues or pull requests that affect the database layer label Mar 27, 2024
datamweb
datamweb approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codegniter is widely used in shared hosting, I'm glad you removed a limitation.

@kenjis kenjis force-pushed the feat-database-name-with-dot branch from c3fb210 to 927a829 Compare March 28, 2024 02:11
@kenjis
Copy link
Member Author

kenjis commented Mar 28, 2024

Add notes support dot in database since 4.5

Added.

@kenjis kenjis requested a review from ddevsr March 28, 2024 02:18
@kenjis kenjis merged commit 33d7d2a into codeigniter4:4.5 Mar 28, 2024
41 checks passed
@kenjis kenjis deleted the feat-database-name-with-dot branch March 28, 2024 02:52
@mbnl
Copy link

mbnl commented Apr 3, 2024

Thank you very much it worked for me. #8647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevsr ddevsr ddevsr approved these changes

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 database Issues or pull requests that affect the database layer enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kenjis @mbnl @michalsn @datamweb @ddevsr