fix: lang() may return false #7966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
neznaika0
reviewed
Sep 24, 2023
|
|
||
| $this->expectException(InvalidArgumentException::class); | ||
| $this->expectExceptionMessage( | ||
| 'Invalid message format: "تم الكشف عن كلمة المرور {0} بسبب اختراق البيانات وشوهدت {1 ، عدد} مرة في {2} في كلمات المرور المخترقة.", args: "password,hits,wording"' |
There was a problem hiding this comment.
Is this normal (language) for tests?
There was a problem hiding this comment.
Yes it might be better to make a comment as to explain testing of Arabic as international languages.
|
|
||
| $this->expectException(InvalidArgumentException::class); | ||
| $this->expectExceptionMessage( | ||
| 'Invalid message format: "تم الكشف عن كلمة المرور {0} بسبب اختراق البيانات وشوهدت {1 ، عدد} مرة في {2} في كلمات المرور المخترقة.", args: "password,hits,wording"' |
There was a problem hiding this comment.
Requesting comment for test language
datamweb
reviewed
Sep 25, 2023
| * the LICENSE file that was distributed with this source code. | ||
| */ | ||
|
|
||
| // "Language" language settings |
There was a problem hiding this comment.
Suggested change
| // "Language" language settings |
I don't think it is necessary.
datamweb
approved these changes
Sep 25, 2023
TimexPeachtree
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See codeigniter4/shield#851
Language::formatMessage()Language.invalidMessageFormatChecklist: