[PHPStan] Add @var string[] on array of string, detected by enable StringifyStrNeedlesRector #7940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trNeedlesRector
kenjis
reviewed
Sep 14, 2023
system/Commands/Utilities/Routes/AutoRouterImproved/ControllerMethodReader.php
Outdated
Show resolved
Hide resolved
kenjis
reviewed
Sep 14, 2023
kenjis
reviewed
Sep 14, 2023
kenjis
reviewed
Sep 14, 2023
…MethodReader.php Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
|
@kenjis updated 👍 |
datamweb
reviewed
Sep 14, 2023
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
samsonasik
commented
Sep 14, 2023
system/Commands/Utilities/Routes/AutoRouterImproved/ControllerMethodReader.php
Outdated
Show resolved
Hide resolved
|
@datamweb updated 👍 |
kenjis
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
with enable
StringifyStrNeedlesRector, the cast(string)is applied to array data with mixed type.This PR apply
@var string[]so it skipped byStringifyStrNeedlesRectorcorrectly.https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#stringifystrneedlesrector
Checklist: