-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] refactor: moving RedirectException. #7545
Conversation
0891ccc
to
6cffb87
Compare
If there is code that throws Why don't you catch the deprecated class in the framework code for backward compatibility? |
Nice catch. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
@iRedds Thank you! |
Description
Currently the
RedirectException
class is in theCodeIgniter\Router\Exceptions
namespace.I believe this exception is not related to routes but to the HTTP layer. Therefore, I propose to move it to the appropriate namespace.
The old class is marked as deprecated.
Checklist: