Skip to content

docs: improve PHPDoc for model() #7254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2023
Merged

docs: improve PHPDoc for model() #7254

merged 1 commit into from
Feb 15, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 15, 2023

Description
See #7224

  • make the PHPDoc type more accurate

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@samsonasik samsonasik merged commit 356c0b9 into codeigniter4:develop Feb 15, 2023
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-phpdoc-model branch February 16, 2023 00:34
@paulbalandan paulbalandan mentioned this pull request Jul 6, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @samsonasik @MGatner