Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Email] add fallback to use gethostname() #7053

Merged
merged 1 commit into from
Jan 7, 2023
Merged

fix: [Email] add fallback to use gethostname() #7053

merged 1 commit into from
Jan 7, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 6, 2023

Description
[127.0.0.1] is not valid domain parameter.
127.0.0.1 is a loopback address.

See https://forum.codeigniter.com/showthread.php?tid=84852

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
fix: add fallback to use gethostname()
5137cb6 
[127.0.0.1] is not valid domain parameter.
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 6, 2023
@kenjis kenjis merged commit 72adf69 into codeigniter4:develop Jan 7, 2023
@kenjis kenjis deleted the fix-Email-getHostname branch January 7, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @samsonasik @paulbalandan