Skip to content

fix: define of STDOUT in CLI init() method #7052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

jozefrebjak
Copy link
Contributor

Description

In development and also in production environment where composer dependencies are installed without --no-dev composer flag we can have an issue with running commands from Controller with command() helper.

Issue is there because of Psalm required package amphp/byte-stream in

functions.php

Psalm is often installed with devkit, so we need to check if STDOUT is already defined.

Fixes #7047

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 5, 2023
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@kenjis kenjis merged commit e9da460 into codeigniter4:develop Jan 5, 2023
@kenjis
Copy link
Member

kenjis commented Jan 5, 2023

Okay. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Constant STDOUT already defined
5 participants