refactor: add Config\Session - #6989
Merged
Merged
Conversation
kenjis
marked this pull request as draft
December 17, 2022 10:53
kenjis
force-pushed
the
refactor-add-session-config
branch
from
December 17, 2022 10:57
47b673b to
8edd149
Compare
kenjis
force-pushed
the
refactor-add-session-config
branch
from
December 17, 2022 11:06
287eaa3 to
97eb3a7
Compare
kenjis
added
the
docs needed
kenjis
force-pushed
the
refactor-add-session-config
branch
2 times, most recently
from
December 17, 2022 12:28
d4a8a1d to
a258508
Compare
kenjis
force-pushed
the
refactor-add-session-config
branch
from
December 17, 2022 12:30
a258508 to
778c412
Compare
kenjis
removed
the
docs needed
kenjis
marked this pull request as ready for review
December 18, 2022 01:32
michalsn
approved these changes
Dec 18, 2022
MGatner
requested changes
Dec 18, 2022
MGatner
left a comment
MGatner
left a comment
Member
There was a problem hiding this comment.
I haven't made it through all the changes to tests yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related: #4297 (comment)
Checklist: