Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MigrationRunnerTest for Windows #6855

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Fix MigrationRunnerTest for Windows #6855

merged 1 commit into from
Nov 14, 2022

Conversation

paulbalandan
Copy link
Member

Description
The different directory separators mess up local testing

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Nov 13, 2022
MGatner
MGatner approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I don't like realpath calls without fallback, because they fail in virtual file systems, but I think this is safe.

@paulbalandan
Copy link
Member Author

Yes, but realpath() returning false will be beneficial in this case when the file is missing as the test would catch that.

@paulbalandan paulbalandan merged commit 7578a48 into codeigniter4:develop Nov 14, 2022
@paulbalandan paulbalandan deleted the migration-runner-test branch November 14, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @MGatner