refactor: DOMParser::withString() for PHP 8.2

[kenjis]

Description
See #6170
See https://php.watch/versions/8.2/mbstring-qprint-base64-uuencode-html-entities-deprecated

• mb_convert_encoding($str, 'HTML-Entities') is deprecated in PHP 8.2.

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• [] User guide updated
• Conforms to style guide

[MGatner]

I'm having a hard time finding a clear answer: are you sure these are the same?

[MGatner]

Compare: Kristories/symfony@eea3b10

[kenjis]

The latest code in Symfony is different.

$this->line = htmlspecialchars_decode(utf8_decode(htmlentities($this->line, ENT_COMPAT, 'UTF-8', false)));

https://github.com/Kristories/symfony/blob/eea3b10327c1a9b1298a069ea8f844c70e73b6a7/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php#L981

$this->line = mb_encode_numericentity($this->line, [0x80, 0x10FFFF, 0, 0x1FFFFF], 'UTF-8');

https://github.com/symfony/symfony/blob/b527899f4fb4355fd356eef6f910ea67c5f86192/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php#L939

[kenjis]

I'm having a hard time finding a clear answer: are you sure these are the same?

No. The following tests fail with this PR.

--- a/tests/system/Test/DOMParserTest.php
+++ b/tests/system/Test/DOMParserTest.php
@@ -80,8 +80,9 @@ final class DOMParserTest extends CIUnitTestCase
     public function provideText()
     {
         return [
-            ['Hello World'],
-            ['Hellö Wörld'],
+            'en' => ['Hello World'],
+            'sv' => ['Hej, världen'],
+            'ja' => ['こんにちは、世界'],
         ];
     }
 

[kenjis]

I changed the code, and test case.
But I don't understand the need for the conversion. 😓

[MGatner]

Have you blamed it for any clues? I can look into it later on desktop, but it is a rather baffling feature.

[kenjis]

I think this PR is ready to merge.

[kenjis]

Thanks for the reviews!