Skip to content

refactor: add test for DownloadResponse #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2022
Merged

refactor: add test for DownloadResponse #6375

merged 4 commits into from
Aug 14, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 13, 2022 •
edited
Loading

Description
Follow-up #6361

  • add hack for testing in CodeIgniter.php
  • add test for DownloadResponse
  • fix tests with dynamic property

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code testing Pull requests that changes tests only labels Aug 13, 2022
@MGatner
Copy link
Member

MGatner commented Aug 13, 2022

Cool hack though 😎

@samsonasik samsonasik merged commit cc8758b into codeigniter4:develop Aug 14, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-CodeIgniterTest branch August 14, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @samsonasik