Skip to content

docs: improve controllers.rst #6368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenjis merged 2 commits into from
Aug 11, 2022
Merged

docs: improve controllers.rst #6368

kenjis merged 2 commits into from
Aug 11, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 11, 2022

Description

  • add about constructor
  • update private methods

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Aug 11, 2022
MGatner
MGatner approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@kenjis kenjis mentioned this pull request Aug 11, 2022
Merged
2 tasks
@kenjis kenjis force-pushed the fix-docs-controllers.rst branch from c33e7fd to f9d93ce Compare August 11, 2022 11:50
datamweb
datamweb approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full and detailed description!

@kenjis kenjis merged commit 00c6596 into codeigniter4:develop Aug 11, 2022
@kenjis kenjis deleted the fix-docs-controllers.rst branch August 11, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @MGatner