Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $cached param to BaseConnection::tableExists() #6364

Merged
merged 6 commits into from
Aug 15, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
sclubricants committed Aug 14, 2022
commit 8077f2f565a2b5bc5266e1b4a36a7b058e4effea
2 changes: 1 addition & 1 deletion system/Database/BaseConnection.php
Original file line number Diff line number Diff line change
Expand Up @@ -1604,7 +1604,7 @@ abstract public function insertID();
/**
* Generates the SQL for listing tables in a platform-dependent manner.
*
* @param null|string $tableName If $tableName is provided will return only this table if exists.
* @param string|null $tableName If $tableName is provided will return only this table if exists.
*
* @return false|string
*/
Expand Down
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Connection.php
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ public function escapeLikeStringDirect($str)
* Generates the SQL for listing tables in a platform-dependent manner.
* Uses escapeLikeStringDirect().
*
* @param null|string $tableName If $tableName is provided will return only this table if exists.
* @param string|null $tableName If $tableName is provided will return only this table if exists.
*/
protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
{
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Connection.php
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ public function affectedRows(): int
/**
* Generates the SQL for listing tables in a platform-dependent manner.
*
* @param null|string $tableName If $tableName is provided will return only this table if exists.
* @param string|null $tableName If $tableName is provided will return only this table if exists.
*/
protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
{
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Connection.php
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ protected function _escapeString(string $str): string
/**
* Generates the SQL for listing tables in a platform-dependent manner.
*
* @param null|string $tableName If $tableName is provided will return only this table if exists.
* @param string|null $tableName If $tableName is provided will return only this table if exists.
*/
protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
{
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Connection.php
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public function insertID(): int
/**
* Generates the SQL for listing tables in a platform-dependent manner.
*
* @param null|string $tableName If $tableName is provided will return only this table if exists.
* @param string|null $tableName If $tableName is provided will return only this table if exists.
*/
protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
{
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLite3/Connection.php
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ protected function _escapeString(string $str): string
/**
* Generates the SQL for listing tables in a platform-dependent manner.
*
* @param null|string $tableName If $tableName is provided will return only this table if exists.
* @param string|null $tableName If $tableName is provided will return only this table if exists.
*/
protected function _listTables(bool $prefixLimit = false, ?string $tableName = null): string
{
Expand Down
2 changes: 1 addition & 1 deletion system/Test/Mock/MockConnection.php
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ public function insertID(): int
/**
* Generates the SQL for listing tables in a platform-dependent manner.
*
* @param null|string $tableName If $tableName is provided will return only this table if exists.
* @param string|null $tableName If $tableName is provided will return only this table if exists.
*/
protected function _listTables(bool $constrainByPrefix = false, ?string $tableName = null): string
{
Expand Down