Skip to content

chore: Sphinx convert warning into error #6359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2022
Merged

chore: Sphinx convert warning into error #6359

merged 3 commits into from
Aug 9, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 8, 2022 •
edited
Loading

Description

  • convert warning into error
  • refactor sample code

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Aug 8, 2022
@kenjis kenjis marked this pull request as draft August 8, 2022 12:47
kenjis added 2 commits August 8, 2022 21:49
@kenjis
docs: refactor sample code
b471880 
Anonymous class can't be processed with Sphinx now.
user_guide_src/source/database/utilities.rst:20:Could not lex literal_block as "html+php". Highlighting skipped.
@kenjis
chore: tweak options
09bcef4
@kenjis kenjis force-pushed the make-sphinx-warning-to-error branch from 62f3c7b to 09bcef4 Compare August 8, 2022 13:20
@kenjis kenjis added the documentation Pull requests for documentation only label Aug 8, 2022
@kenjis kenjis marked this pull request as ready for review August 8, 2022 13:22
@kenjis kenjis mentioned this pull request Aug 8, 2022
Merged
5 tasks
MGatner
MGatner approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that research @kenjis!

@kenjis kenjis merged commit 1086703 into codeigniter4:develop Aug 9, 2022
@kenjis kenjis deleted the make-sphinx-warning-to-error branch August 9, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner