Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong FROM provided after reset query #4463

Closed
wants to merge 3 commits into from
Closed

Fix wrong FROM provided after reset query #4463

wants to merge 3 commits into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 22, 2021

Description
Fixes #4461

I'm not sure this can be perfect. But the first attempt to fix it.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request Mar 22, 2021
Open
@kenjis
Copy link
Member Author

kenjis commented Mar 22, 2021

It seems that how to reset FROM is not what I had in mind.

@kenjis kenjis marked this pull request as draft March 22, 2021 04:59
@kenjis kenjis marked this pull request as ready for review March 22, 2021 05:23
@iRedds
Copy link
Collaborator

iRedds commented Mar 22, 2021

Maybe it would be more correct to use $this->getTable() instead of $this->tableName?
I dont know.
I like this solution if we consider it within the current concept.

@kenjis kenjis added the database Issues or pull requests that affect the database layer label Nov 20, 2021
@kenjis kenjis closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: shared BaseBuilder instance and Model
2 participants
@kenjis @iRedds