Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Parser with similar variable names #3749

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Oct 9, 2020

Description
This PR fixes error in Parser when similar variable names would be treated as the same.

Fixes #3726

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • Conforms to style guide

@hurtsky
Copy link

hurtsky commented Oct 13, 2020

Looks like this PR fixed the issue. Thanks

@samsonasik samsonasik merged commit 51a5452 into codeigniter4:develop Oct 14, 2020
@samsonasik
Copy link
Member

Thank you @michalsn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Parser will overwrite the value if the initial variable is same
3 participants