Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for multicolored strings in CLI #3175

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Fix for multicolored strings in CLI #3175

merged 2 commits into from
Jun 28, 2020

Conversation

michalsn
Copy link
Member

Description
This PR fixes multicolored strings in CLI. See: #3173

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
Copy link
Member Author

@paulbalandan I hope you find some time after weekend and test this on Windows :)

@paulbalandan
Copy link
Member

@michalsn this solution works like a charm. Thanks.

@paulbalandan
Copy link
Member

On a different note. I don't know if this is worthy of a bug report but CLITest::testWrap always fails on Windows tests. I'll investigate further and let you know. Anyway, thank you.

samsonasik
samsonasik reviewed Jun 28, 2020
View reviewed changes
@michalsn michalsn merged commit de968b7 into codeigniter4:develop Jun 28, 2020
@michalsn michalsn deleted the cli_color branch July 3, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalsn @paulbalandan @samsonasik