Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When controller and method are both empty and there is no explicit default route (i.e.
$routes->get('/', ...
) then Router will callvalidateRequest()
with two blank entries in$segments
, which in turn callssetDirectory('')
twice resulting in a directory of//
. This causesautoroute()
to fail to locate existing controllers.This PR has
setDirectory()
ignore empty requests, since$this->directory
ofnull
is already equivalent to/
.Fix for #2301
Checklist: