Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String type primary key should also wrap into an array during db update #1963

Merged
merged 1 commit into from
Apr 25, 2019
Merged

String type primary key should also wrap into an array during db update #1963

merged 1 commit into from
Apr 25, 2019

Conversation

vibbow
Copy link
Contributor

@vibbow vibbow commented Apr 22, 2019

Description
String type primary key should also wrap into an array during db update
Following $builder->whereIn() expect it to be an array.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 7f922f0 into codeigniter4:develop Apr 25, 2019
@vibbow vibbow deleted the pr_fix_update_pk_issue branch April 25, 2019 03:29
@MGatner MGatner mentioned this pull request May 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vibbow @lonnieezell